Skip to content

Commit

Permalink
crypto: s5p-sss - Remove useless check for non-null request
Browse files Browse the repository at this point in the history
ahash_request 'req' argument passed by the caller
s5p_hash_handle_queue() cannot be NULL here because it is obtained from
non-NULL pointer via container_of().

This fixes smatch warning:
    drivers/crypto/s5p-sss.c:1213 s5p_hash_prepare_request() warn: variable dereferenced before check 'req' (see line 1208)

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Krzysztof Kozlowski authored and Herbert Xu committed Mar 9, 2018
1 parent 17f5b19 commit 0e477c5
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/crypto/s5p-sss.c
Original file line number Diff line number Diff line change
Expand Up @@ -1210,9 +1210,6 @@ static int s5p_hash_prepare_request(struct ahash_request *req, bool update)
int xmit_len, hash_later, nbytes;
int ret;

if (!req)
return 0;

if (update)
nbytes = req->nbytes;
else
Expand Down

0 comments on commit 0e477c5

Please sign in to comment.