Skip to content

Commit

Permalink
platform/x86: dell-smbios: Fix memory leaks in build_tokens_sysfs()
Browse files Browse the repository at this point in the history
We're freeing "value_name" which is NULL, so that's a no-op, but we
intended to free "location_name" instead.  And then we don't free the
names in token_location_attrs[0] and token_value_attrs[0].

Fixes: 33b9ca1 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  • Loading branch information
Dan Carpenter authored and Andy Shevchenko committed Apr 2, 2018
1 parent 2b5de0c commit 0e5b09b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/platform/x86/dell-smbios-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
continue;

loop_fail_create_value:
kfree(value_name);
kfree(location_name);
goto out_unwind_strings;
}
smbios_attribute_group.attrs = token_attrs;
Expand All @@ -525,7 +525,7 @@ static int build_tokens_sysfs(struct platform_device *dev)
return 0;

out_unwind_strings:
for (i = i-1; i > 0; i--) {
while (i--) {
kfree(token_location_attrs[i].attr.name);
kfree(token_value_attrs[i].attr.name);
}
Expand Down

0 comments on commit 0e5b09b

Please sign in to comment.