Skip to content

Commit

Permalink
drm/i915: Trim the flush for the execlists request emission
Browse files Browse the repository at this point in the history
At the start of request emission, we flush some space for the request,
estimating the typical size for the request body. The common tail is now
much larger than the typical body, so we can shrink the flush
substantially.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1461917226-9132-3-git-send-email-chris@chris-wilson.co.uk
  • Loading branch information
Chris Wilson committed Apr 29, 2016
1 parent a044246 commit 0e93cdd
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/gpu/drm/i915/intel_lrc.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ enum {
#define GEN8_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT 0x17
#define GEN9_CTX_RCS_INDIRECT_CTX_OFFSET_DEFAULT 0x26

/* Typical size of the average request (2 pipecontrols and a MI_BB) */
#define EXECLISTS_REQUEST_SIZE 64 /* bytes */

static int execlists_context_deferred_alloc(struct intel_context *ctx,
struct intel_engine_cs *engine);
static int intel_lr_context_pin(struct intel_context *ctx,
Expand Down Expand Up @@ -681,7 +684,7 @@ int intel_logical_ring_alloc_request_extras(struct drm_i915_gem_request *request
* we start building the request - in which case we will just
* have to repeat work.
*/
request->reserved_space += MIN_SPACE_FOR_ADD_REQUEST;
request->reserved_space += EXECLISTS_REQUEST_SIZE;

if (request->ctx->engine[engine->id].state == NULL) {
ret = execlists_context_deferred_alloc(request->ctx, engine);
Expand Down Expand Up @@ -727,7 +730,7 @@ int intel_logical_ring_alloc_request_extras(struct drm_i915_gem_request *request
* to cancel/unwind this request now.
*/

request->reserved_space -= MIN_SPACE_FOR_ADD_REQUEST;
request->reserved_space -= EXECLISTS_REQUEST_SIZE;
return 0;

err_unpin:
Expand Down

0 comments on commit 0e93cdd

Please sign in to comment.