Skip to content

Commit

Permalink
Subject: [PATCH] tags.sh: Add missing quotes
Browse files Browse the repository at this point in the history
When $remove_structs is empty a test for empty string will turn
into test -n with no arguments meaning true. Add quotes so an
empty string is tested and so that make cscope works again.

Reported-and-tested-by: Jike Song <albcamus@gmail.com>
Reported-by: Prarit Bhargava <prarit@redhat.com>
Acked-by: Yang Bai <hamo.by@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
  • Loading branch information
Stephen Boyd authored and Michal Marek committed Apr 2, 2012
1 parent dd775ae commit 0eb043d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/tags.sh
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,6 @@ case "$1" in
esac

# Remove structure forward declarations.
if [ -n $remove_structs ]; then
if [ -n "$remove_structs" ]; then
LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
fi

0 comments on commit 0eb043d

Please sign in to comment.