Skip to content

Commit

Permalink
crypto: atmel-{sha,tdes} - Propagate error from _hw_version_init()
Browse files Browse the repository at this point in the history
atmel_{sha,tdes}_hw_version_init() calls atmel_{sha,tdes}_hw_init(),
which may fail. Check the return code of atmel_{sha,tdes}_hw_init()
and propagate the error if needed.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Tudor Ambarus authored and Herbert Xu committed Dec 11, 2019
1 parent fb24307 commit 0efe58f
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 6 deletions.
14 changes: 11 additions & 3 deletions drivers/crypto/atmel-sha.c
Original file line number Diff line number Diff line change
Expand Up @@ -1038,16 +1038,22 @@ static inline unsigned int atmel_sha_get_version(struct atmel_sha_dev *dd)
return atmel_sha_read(dd, SHA_HW_VERSION) & 0x00000fff;
}

static void atmel_sha_hw_version_init(struct atmel_sha_dev *dd)
static int atmel_sha_hw_version_init(struct atmel_sha_dev *dd)
{
atmel_sha_hw_init(dd);
int err;

err = atmel_sha_hw_init(dd);
if (err)
return err;

dd->hw_version = atmel_sha_get_version(dd);

dev_info(dd->dev,
"version: 0x%x\n", dd->hw_version);

clk_disable(dd->iclk);

return 0;
}

static int atmel_sha_handle_queue(struct atmel_sha_dev *dd,
Expand Down Expand Up @@ -2789,7 +2795,9 @@ static int atmel_sha_probe(struct platform_device *pdev)
if (err)
goto res_err;

atmel_sha_hw_version_init(sha_dd);
err = atmel_sha_hw_version_init(sha_dd);
if (err)
goto iclk_unprepare;

atmel_sha_get_cap(sha_dd);

Expand Down
14 changes: 11 additions & 3 deletions drivers/crypto/atmel-tdes.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,16 +236,22 @@ static inline unsigned int atmel_tdes_get_version(struct atmel_tdes_dev *dd)
return atmel_tdes_read(dd, TDES_HW_VERSION) & 0x00000fff;
}

static void atmel_tdes_hw_version_init(struct atmel_tdes_dev *dd)
static int atmel_tdes_hw_version_init(struct atmel_tdes_dev *dd)
{
atmel_tdes_hw_init(dd);
int err;

err = atmel_tdes_hw_init(dd);
if (err)
return err;

dd->hw_version = atmel_tdes_get_version(dd);

dev_info(dd->dev,
"version: 0x%x\n", dd->hw_version);

clk_disable_unprepare(dd->iclk);

return 0;
}

static void atmel_tdes_dma_callback(void *data)
Expand Down Expand Up @@ -1291,7 +1297,9 @@ static int atmel_tdes_probe(struct platform_device *pdev)
goto res_err;
}

atmel_tdes_hw_version_init(tdes_dd);
err = atmel_tdes_hw_version_init(tdes_dd);
if (err)
goto res_err;

atmel_tdes_get_cap(tdes_dd);

Expand Down

0 comments on commit 0efe58f

Please sign in to comment.