Skip to content

Commit

Permalink
x86/Xen: don't report ancient LAPIC version
Browse files Browse the repository at this point in the history
Unconditionally reporting a value seen on the P4 or older invokes
functionality like io_apic_get_unique_id() on 32-bit builds, resulting
in a panic() with sufficiently many CPUs and/or IO-APICs. Doing what
that function does would be the hypervisor's responsibility anyway, so
makes no sense to be used when running on Xen. Uniformly report a more
modern version; this shouldn't matter much as both LAPIC and IO-APIC are
being managed entirely / mostly by the hypervisor.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
  • Loading branch information
Jan Beulich authored and Boris Ostrovsky committed Dec 12, 2017
1 parent 1ab134c commit 0f3922a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/xen/apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ static u32 xen_apic_read(u32 reg)
return 0;

if (reg == APIC_LVR)
return 0x10;
return 0x14;
#ifdef CONFIG_X86_32
if (reg == APIC_LDR)
return SET_APIC_LOGICAL_ID(1UL << smp_processor_id());
Expand Down

0 comments on commit 0f3922a

Please sign in to comment.