Skip to content

Commit

Permalink
coredump: use SUID_DUMPABLE_ENABLED rather than hardcoded 1
Browse files Browse the repository at this point in the history 
Cosmetic. Change setup_new_exec() and task_dumpable() to use
SUID_DUMPABLE_ENABLED for /bin/grep.

[akpm@linux-foundation.org: checkpatch fixes]
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Oct 5, 2012
1 parent 12a2b4b commit 0f4cfb2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion fs/exec.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ void setup_new_exec(struct linux_binprm * bprm)
current->sas_ss_sp = current->sas_ss_size = 0;

if (uid_eq(current_euid(), current_uid()) && gid_eq(current_egid(), current_gid()))
set_dumpable(current->mm, 1);
set_dumpable(current->mm, SUID_DUMPABLE_ENABLED);
else
set_dumpable(current->mm, suid_dumpable);

Expand Down
2 changes: 1 addition & 1 deletion fs/proc/internal.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ static inline int task_dumpable(struct task_struct *task)
if (mm)
dumpable = get_dumpable(mm);
task_unlock(task);
if(dumpable == 1)
if (dumpable == SUID_DUMPABLE_ENABLED)
return 1;
return 0;
}
Expand Down

0 comments on commit 0f4cfb2

Please sign in to comment.