Skip to content

Commit

Permalink
dma: timb-dma: Update comment and fix compiler warning
Browse files Browse the repository at this point in the history
An incremental patch which clarifies what the spinlock is used for
and fixes a compiler warning.

Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Richard Röjfors authored and Dan Williams committed Mar 26, 2010
1 parent de5d445 commit 0f65169
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/dma/timb_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ struct timb_dma_desc {
struct timb_dma_chan {
struct dma_chan chan;
void __iomem *membase;
spinlock_t lock; /* Used for mutual exclusion */
spinlock_t lock; /* Used to protect data structures,
especially the lists and descriptors,
from races between the tasklet and calls
from above */
dma_cookie_t last_completed_cookie;
bool ongoing;
struct list_head active_list;
Expand Down Expand Up @@ -197,7 +200,7 @@ static int td_fill_desc(struct timb_dma_chan *td_chan, u8 *dma_desc,
}

dev_dbg(chan2dev(&td_chan->chan), "desc: %p, addr: %p\n",
dma_desc, (void *)(int)sg_dma_address(sg));
dma_desc, (void *)sg_dma_address(sg));

dma_desc[7] = (sg_dma_address(sg) >> 24) & 0xff;
dma_desc[6] = (sg_dma_address(sg) >> 16) & 0xff;
Expand Down

0 comments on commit 0f65169

Please sign in to comment.