Skip to content

Commit

Permalink
gpio: mmio: remove untrue leftover comment
Browse files Browse the repository at this point in the history
The comment should have been removed when new GPIO direction
definitions were taken in use as the function logic was changed. It
is now perfectly valid and Ok to hit the return from the bottom of
the direction getting function.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
  • Loading branch information
Matti Vaittinen authored and Bartosz Golaszewski committed Nov 13, 2019
1 parent be053b2 commit 0f67f16
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/gpio/gpio-mmio.c
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,6 @@ static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio)
if (!(gc->read_reg(gc->reg_dir_in) & bgpio_line2mask(gc, gpio)))
return GPIO_LINE_DIRECTION_OUT;

/* This should not happen */
return GPIO_LINE_DIRECTION_IN;
}

Expand Down

0 comments on commit 0f67f16

Please sign in to comment.