Skip to content

Commit

Permalink
cxl/pci: Delay event buffer allocation
Browse files Browse the repository at this point in the history
The event buffer does not need to be allocated if something has failed in
setting up event irq's.

In prep for adjusting event configuration for DCD events move the buffer
allocation to the end of the event configuration.

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Li Ming <ming4.li@intel.com>
Link: https://lore.kernel.org/all/663922b475e50_d54d72945b@dwillia2-xfh.jf.intel.com.notmuch/ [1]
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20241107-dcd-type2-upstream-v7-4-56a84e66bc36@intel.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
  • Loading branch information
Ira Weiny authored and Dave Jiang committed Nov 8, 2024
1 parent f88b3ec commit 0f6f0d6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/cxl/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -764,10 +764,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
return 0;
}

rc = cxl_mem_alloc_event_buf(mds);
if (rc)
return rc;

rc = cxl_event_get_int_policy(mds, &policy);
if (rc)
return rc;
Expand All @@ -781,6 +777,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
return -EBUSY;
}

rc = cxl_mem_alloc_event_buf(mds);
if (rc)
return rc;

rc = cxl_event_irqsetup(mds);
if (rc)
return rc;
Expand Down

0 comments on commit 0f6f0d6

Please sign in to comment.