Skip to content

Commit

Permalink
qla3xxx: Don't sleep while holding lock.
Browse files Browse the repository at this point in the history
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ron Mercer authored and David S. Miller committed Jun 23, 2009
1 parent e5a6737 commit 0f77ca9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/qla3xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -3142,6 +3142,7 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev)
(void __iomem *)port_regs;
u32 delay = 10;
int status = 0;
unsigned long hw_flags = 0;

if(ql_mii_setup(qdev))
return -1;
Expand Down Expand Up @@ -3351,7 +3352,9 @@ static int ql_adapter_initialize(struct ql3_adapter *qdev)
value = ql_read_page0_reg(qdev, &port_regs->portStatus);
if (value & PORT_STATUS_IC)
break;
spin_unlock_irqrestore(&qdev->hw_lock, hw_flags);
msleep(500);
spin_lock_irqsave(&qdev->hw_lock, hw_flags);
} while (--delay);

if (delay == 0) {
Expand Down

0 comments on commit 0f77ca9

Please sign in to comment.