Skip to content

Commit

Permalink
pid namespaces: allow signalling cgroup-init
Browse files Browse the repository at this point in the history
Only the global-init process must be special - any other cgroup-init
process must be killable to prevent run-away processes in the system.

TODO: 	Ideally we should allow killing the cgroup-init only from parent
	cgroup and prevent it being killed from within the cgroup.
	But that is a more complex change and will be addressed by a follow-on
	patch. For now allow the cgroup-init to be terminated by any process
	with sufficient privileges.

Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Cc: Paul Menage <menage@google.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Sukadev Bhattiprolu authored and Linus Torvalds committed Oct 19, 2007
1 parent c9c5d92 commit 0fbc26a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1835,11 +1835,9 @@ int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka,
continue;

/*
* Init of a pid space gets no signals it doesn't want from
* within that pid space. It can of course get signals from
* its parent pid space.
* Global init gets no signals it doesn't want.
*/
if (current == task_child_reaper(current))
if (is_global_init(current))
continue;

if (sig_kernel_stop(signr)) {
Expand Down

0 comments on commit 0fbc26a

Please sign in to comment.