Skip to content

Commit

Permalink
exit/r8188eu: Replace the macro thread_exit with a simple return 0
Browse files Browse the repository at this point in the history
The macro thread_exit is called is at the end of functions started
with kthread_run.  The code in kthread_run has arranged things so a
kernel thread can just return and do_exit will be called.

So just have rtw_cmd_thread and mp_xmit_packet_thread return instead
of calling complete_and_exit.

Link: https://lkml.kernel.org/r/20211020174406.17889-20-ebiederm@xmission.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
  • Loading branch information
Eric W. Biederman committed Oct 29, 2021
1 parent 99d7ef1 commit 0fdc0c4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/r8188eu/core/rtw_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ int rtw_cmd_thread(void *context)

up(&pcmdpriv->terminate_cmdthread_sema);

thread_exit();
return 0;
}

u8 rtw_setstandby_cmd(struct adapter *padapter, uint action)
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/r8188eu/core/rtw_mp.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ static int mp_xmit_packet_thread(void *context)
pmptx->pallocated_buf = NULL;
pmptx->stop = 1;

thread_exit();
return 0;
}

void fill_txdesc_for_mp(struct adapter *padapter, struct tx_desc *ptxdesc)
Expand Down
2 changes: 0 additions & 2 deletions drivers/staging/r8188eu/include/osdep_service.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ struct __queue {
spinlock_t lock;
};

#define thread_exit() complete_and_exit(NULL, 0)

static inline struct list_head *get_list_head(struct __queue *queue)
{
return (&(queue->queue));
Expand Down

0 comments on commit 0fdc0c4

Please sign in to comment.