Skip to content

Commit

Permalink
rtc: ds1307: use sysfs_emit() to instead of scnprintf()
Browse files Browse the repository at this point in the history
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212051134455911470@zte.com.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
  • Loading branch information
ye xingchen authored and Alexandre Belloni committed Dec 15, 2022
1 parent bb0a179 commit 0feebde
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/rtc/rtc-ds1307.c
Original file line number Diff line number Diff line change
Expand Up @@ -1219,8 +1219,7 @@ static ssize_t frequency_test_show(struct device *dev,

regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);

return scnprintf(buf, PAGE_SIZE, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" :
"off\n");
return sysfs_emit(buf, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" : "off\n");
}

static DEVICE_ATTR_RW(frequency_test);
Expand Down

0 comments on commit 0feebde

Please sign in to comment.