Skip to content

Commit

Permalink
fm10k: only warn when stop_hw fails with FM10K_ERR_REQUESTS_PENDING
Browse files Browse the repository at this point in the history
When stop_hw() routine fails with FM10K_ERR_REQUESTS_PENDING, this
indicates that the Tx or Rx queues did not shutdown within the time
limit. Print a more suitable message at the dev_info level instead of
dev_err.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Jacob Keller authored and Jeff Kirsher committed Jul 20, 2016
1 parent 34bad71 commit 106ca42
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/net/ethernet/intel/fm10k/fm10k_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1644,7 +1644,10 @@ void fm10k_down(struct fm10k_intfc *interface)

/* Disable DMA engine for Tx/Rx */
err = hw->mac.ops.stop_hw(hw);
if (err)
if (err == FM10K_ERR_REQUESTS_PENDING)
dev_info(&interface->pdev->dev,
"due to pending requests hw was not shut down gracefully\n");
else if (err)
dev_err(&interface->pdev->dev, "stop_hw failed: %d\n", err);

/* free any buffers still on the rings */
Expand Down

0 comments on commit 106ca42

Please sign in to comment.