Skip to content

Commit

Permalink
net: dsa: realtek: make interface drivers depend on OF
Browse files Browse the repository at this point in the history
The kernel test robot reported build warnings with a randconfig that
built realtek-{smi,mdio} without CONFIG_OF set. Since both interface
drivers are using OF and will not probe without, add the corresponding
dependency to Kconfig.

Link: https://lore.kernel.org/all/202203231233.Xx73Y40o-lkp@intel.com/
Link: https://lore.kernel.org/all/202203231439.ycl0jg50-lkp@intel.com/
Fixes: aac9400 ("net: dsa: realtek: add new mdio interface for drivers")
Fixes: 765c39a ("net: dsa: realtek: convert subdrivers into modules")
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Link: https://lore.kernel.org/r/20220323124225.91763-1-alvin@pqrs.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Alvin Šipraga authored and Jakub Kicinski committed Mar 25, 2022
1 parent ffba212 commit 109d899
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/dsa/realtek/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ menuconfig NET_DSA_REALTEK
config NET_DSA_REALTEK_MDIO
tristate "Realtek MDIO connected switch driver"
depends on NET_DSA_REALTEK
depends on OF
help
Select to enable support for registering switches configured
through MDIO.

config NET_DSA_REALTEK_SMI
tristate "Realtek SMI connected switch driver"
depends on NET_DSA_REALTEK
depends on OF
help
Select to enable support for registering switches connected
through SMI.
Expand Down

0 comments on commit 109d899

Please sign in to comment.