Skip to content

Commit

Permalink
clk: Don't try to use a struct clk* after it could have been freed
Browse files Browse the repository at this point in the history
As __clk_release could call kfree on clk and then we wouldn't have a safe way
of getting the module that owns the clock.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: fcb0ee6 ("clk: Implement clk_unregister")
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michael Turquette <mturquette@linaro.org>
  • Loading branch information
Tomeu Vizoso authored and Michael Turquette committed Dec 3, 2014
1 parent 4afbe17 commit 10cdfe5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/clk/clk.c
Original file line number Diff line number Diff line change
Expand Up @@ -2268,14 +2268,17 @@ int __clk_get(struct clk *clk)

void __clk_put(struct clk *clk)
{
struct module *owner;

if (!clk || WARN_ON_ONCE(IS_ERR(clk)))
return;

clk_prepare_lock();
owner = clk->owner;
kref_put(&clk->ref, __clk_release);
clk_prepare_unlock();

module_put(clk->owner);
module_put(owner);
}

/*** clk rate change notifiers ***/
Expand Down

0 comments on commit 10cdfe5

Please sign in to comment.