Skip to content

Commit

Permalink
perf buildid-list: Always show the DSO name
Browse files Browse the repository at this point in the history
Porcelain can ignore it, humans can make more sense of it.

Suggested-by: Frederic Weisbecker <fweisbec@gmail.com>
Suggested-by: Ingo Molnar <mingo@elte.hu>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1258415125-15019-2-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Nov 17, 2009
1 parent 8ffcda1 commit 1124ba7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion tools/perf/Documentation/perf-buildid-list.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ OPTIONS
Don't do ownership validation.
-v::
--verbose::
Be more verbose, showing the name of the DSOs after the buildids.
Be more verbose.

SEE ALSO
--------
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/builtin-buildid-list.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ static const struct option options[] = {
"input file name"),
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
OPT_BOOLEAN('v', "verbose", &verbose,
"be more verbose (show counter open errors, etc)"),
"be more verbose"),
OPT_END()
};

Expand Down
5 changes: 1 addition & 4 deletions tools/perf/util/symbol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1442,10 +1442,7 @@ size_t dsos__fprintf_buildid(FILE *fp)

list_for_each_entry(pos, &dsos, node) {
ret += dso__fprintf_buildid(pos, fp);
if (verbose)
ret += fprintf(fp, " %s\n", pos->long_name);
else
ret += fprintf(fp, "\n");
ret += fprintf(fp, " %s\n", pos->long_name);
}
return ret;
}
Expand Down

0 comments on commit 1124ba7

Please sign in to comment.