Skip to content

Commit

Permalink
asm-generic/io.h: Fix ioport_map() for !CONFIG_GENERIC_IOMAP
Browse files Browse the repository at this point in the history
The !CONFIG_GENERIC_IOMAP version of ioport_map() is wrong.  It returns a
mapped, i.e., virtual, address that can start from zero and completely
ignores the PCI_IOBASE and IO_SPACE_LIMIT that most architectures that use
!CONFIG_GENERIC_MAP define.

Tested-by: Tanmay Inamdar <tinamdar@apm.com>
Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Liviu Dudau authored and Bjorn Helgaas committed Sep 30, 2014
1 parent 52addcf commit 112eeaa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/asm-generic/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ static inline void iounmap(void __iomem *addr)
#ifndef CONFIG_GENERIC_IOMAP
static inline void __iomem *ioport_map(unsigned long port, unsigned int nr)
{
return (void __iomem *) port;
return PCI_IOBASE + (port & IO_SPACE_LIMIT);
}

static inline void ioport_unmap(void __iomem *p)
Expand Down

0 comments on commit 112eeaa

Please sign in to comment.