Skip to content

Commit

Permalink
s390: get rid of odd global real_memory_size
Browse files Browse the repository at this point in the history
The variable real_memory_size has odd semantics and has been used in
a broken way by e.g. the old kvm code.
Therefore get rid of it before anybody else makes use of it.

Reviewed-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Heiko Carstens authored and Martin Schwidefsky committed May 2, 2013
1 parent edefc71 commit 118131a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
1 change: 0 additions & 1 deletion arch/s390/include/asm/setup.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ struct mem_chunk {
};

extern struct mem_chunk memory_chunk[];
extern unsigned long real_memory_size;
extern int memory_end_set;
extern unsigned long memory_end;

Expand Down
19 changes: 11 additions & 8 deletions arch/s390/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -502,12 +502,10 @@ static void __init setup_resources(void)
}
}

unsigned long real_memory_size;
EXPORT_SYMBOL_GPL(real_memory_size);

static void __init setup_memory_end(void)
{
unsigned long vmax, vmalloc_size, tmp;
unsigned long real_memory_size = 0;
int i;


Expand All @@ -517,7 +515,6 @@ static void __init setup_memory_end(void)
memory_end_set = 1;
}
#endif
real_memory_size = 0;
memory_end &= PAGE_MASK;

/*
Expand Down Expand Up @@ -719,16 +716,22 @@ static struct notifier_block kdump_mem_nb = {
static void reserve_oldmem(void)
{
#ifdef CONFIG_CRASH_DUMP
unsigned long real_size = 0;
int i;

if (!OLDMEM_BASE)
return;
for (i = 0; i < MEMORY_CHUNKS; i++) {
struct mem_chunk *chunk = &memory_chunk[i];

real_size = max(real_size, chunk->addr + chunk->size);
}
reserve_kdump_bootmem(OLDMEM_BASE, OLDMEM_SIZE, CHUNK_OLDMEM);
reserve_kdump_bootmem(OLDMEM_SIZE, memory_end - OLDMEM_SIZE,
CHUNK_OLDMEM);
if (OLDMEM_BASE + OLDMEM_SIZE == real_memory_size)
reserve_kdump_bootmem(OLDMEM_SIZE, real_size - OLDMEM_SIZE, CHUNK_OLDMEM);
if (OLDMEM_BASE + OLDMEM_SIZE == real_size)
saved_max_pfn = PFN_DOWN(OLDMEM_BASE) - 1;
else
saved_max_pfn = PFN_DOWN(real_memory_size) - 1;
saved_max_pfn = PFN_DOWN(real_size) - 1;
#endif
}

Expand Down

0 comments on commit 118131a

Please sign in to comment.