Skip to content

Commit

Permalink
selftests/bpf: More compatible nc options in test_tc_edt
Browse files Browse the repository at this point in the history
Out of the three nc implementations widely in use, at least two (BSD netcat
and nmap-ncat) do not support -l combined with -s. Modify the nc invocation
to be accepted by all of them.

Fixes: 7df5e3d ("selftests: bpf: tc-bpf flow shaping with EDT")
Signed-off-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Peter Oskolkov <posk@google.com>
Link: https://lore.kernel.org/bpf/f5bf07dccd8b552a76c84d49e80b86c5aa071122.1571400024.git.jbenc@redhat.com
  • Loading branch information
Jiri Benc authored and Daniel Borkmann committed Oct 18, 2019
1 parent 9e8acd9 commit 11875ba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/bpf/test_tc_edt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ ip netns exec ${NS_SRC} tc filter add dev veth_src egress \

# start the listener
ip netns exec ${NS_DST} bash -c \
"nc -4 -l -s ${IP_DST} -p 9000 >/dev/null &"
"nc -4 -l -p 9000 >/dev/null &"
declare -i NC_PID=$!
sleep 1

Expand Down

0 comments on commit 11875ba

Please sign in to comment.