Skip to content

Commit

Permalink
drm/i915/fbc: update the panel_replay dependency in fbc wa's
Browse files Browse the repository at this point in the history
There are two panel_replay scenarios fbc wa need to be aware of,
panel replay with and without selective update capability.
Panel replay without selective update don't have any fbc wa.
So keep the fbc psr1 wa as it is.

The current fbc psr2 wa is mainly about selective fetch and we
need to apply the fbc wa if selective fetch is on - irrespective
of panel replay. Hence we can't exclude panel replay from the
fbc psr2 wa.

v1: keep panel_replay exclusion in PSR1 case (Jouni)
    Patch description updated

Bspec: 66624, 50442
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250321094529.197397-3-vinod.govindapillai@intel.com
  • Loading branch information
Vinod Govindapillai committed Mar 24, 2025
1 parent ccdb96c commit 1193835
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/gpu/drm/i915/display/intel_fbc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1472,9 +1472,8 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
* disabling PSR2, keep FBC disabled in case of selective update is on
* until the selection logic is implemented.
*/
if (DISPLAY_VER(display) >= 12 && crtc_state->has_sel_update &&
!crtc_state->has_panel_replay) {
plane_state->no_fbc_reason = "PSR2 enabled";
if (DISPLAY_VER(display) >= 12 && crtc_state->has_sel_update) {
plane_state->no_fbc_reason = "Selective update enabled";
return 0;
}

Expand Down

0 comments on commit 1193835

Please sign in to comment.