Skip to content

Commit

Permalink
crypto: ingenic - Drop kfree for memory allocated with devm_kzalloc
Browse files Browse the repository at this point in the history
It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Fixes: 190873a ("crypto: ingenic - Add hardware RNG for Ingenic JZ4780 and X1000")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Wei Yongjun authored and Herbert Xu committed Aug 21, 2020
1 parent 9a5a668 commit 11a954e
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions drivers/char/hw_random/ingenic-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ static int ingenic_rng_probe(struct platform_device *pdev)
priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
pr_err("%s: Failed to map RNG registers\n", __func__);
ret = PTR_ERR(priv->base);
goto err_free_rng;
return PTR_ERR(priv->base);
}

priv->version = (enum ingenic_rng_version)of_device_get_match_data(&pdev->dev);
Expand All @@ -106,17 +105,13 @@ static int ingenic_rng_probe(struct platform_device *pdev)
ret = hwrng_register(&priv->rng);
if (ret) {
dev_err(&pdev->dev, "Failed to register hwrng\n");
goto err_free_rng;
return ret;
}

platform_set_drvdata(pdev, priv);

dev_info(&pdev->dev, "Ingenic RNG driver registered\n");
return 0;

err_free_rng:
kfree(priv);
return ret;
}

static int ingenic_rng_remove(struct platform_device *pdev)
Expand Down

0 comments on commit 11a954e

Please sign in to comment.