Skip to content

Commit

Permalink
drm/i915/pm: Print offending domain in refcount failure
Browse files Browse the repository at this point in the history
If we experience a refcounting failure in a power domain/well (unref'ing at
least one too many times), log the name of the offending domain or well.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1448034934-11926-2-git-send-email-daniels@collabora.com
  • Loading branch information
Daniel Stone authored and Imre Deak committed Nov 23, 2015
1 parent 9895ad0 commit 11c86db
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/gpu/drm/i915/intel_runtime_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1499,11 +1499,15 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,

mutex_lock(&power_domains->lock);

WARN_ON(!power_domains->domain_use_count[domain]);
WARN(!power_domains->domain_use_count[domain],
"Use count on domain %s is already zero\n",
intel_display_power_domain_str(domain));
power_domains->domain_use_count[domain]--;

for_each_power_well_rev(i, power_well, BIT(domain), power_domains) {
WARN_ON(!power_well->count);
WARN(!power_well->count,
"Use count on power well %s is already zero",
power_well->name);

if (!--power_well->count)
intel_power_well_disable(dev_priv, power_well);
Expand Down

0 comments on commit 11c86db

Please sign in to comment.