Skip to content

Commit

Permalink
netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet
Browse files Browse the repository at this point in the history
In commit b396966 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
I attempted to add safe fragment handling to xt_TCPMSS.  However, Andy Padavan
of Project N56U correctly points out that returning XT_CONTINUE in this
function does not work.  The callers (tcpmss_tg[46]) expect to receive a value
of 0 in order to return XT_CONTINUE.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Phil Oester authored and Pablo Neira Ayuso committed Sep 4, 2013
1 parent 7cc9eb6 commit 1205e1f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netfilter/xt_TCPMSS.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ tcpmss_mangle_packet(struct sk_buff *skb,

/* This is a fragment, no TCP header is available */
if (par->fragoff != 0)
return XT_CONTINUE;
return 0;

if (!skb_make_writable(skb, skb->len))
return -1;
Expand Down

0 comments on commit 1205e1f

Please sign in to comment.