Skip to content

Commit

Permalink
selftests: cgroup: Minor code reorganizations
Browse files Browse the repository at this point in the history
No functional change intended, these small changes are merged into one
commit and they serve as a preparation for an upcoming new testcase.

Signed-off-by: Michal Koutný <mkoutny@suse.com>
Reviewed-by: Waiman Long <longman@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Michal Koutný authored and Tejun Heo committed Jul 10, 2023
1 parent 0a67b84 commit 1210142
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -5222,6 +5222,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git
F: Documentation/admin-guide/cgroup-v1/cpusets.rst
F: include/linux/cpuset.h
F: kernel/cgroup/cpuset.c
F: tools/testing/selftests/cgroup/test_cpuset_prs.sh

CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)
M: Johannes Weiner <hannes@cmpxchg.org>
Expand Down
2 changes: 2 additions & 0 deletions tools/testing/selftests/cgroup/cgroup_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ int cg_destroy(const char *cgroup)
{
int ret;

if (!cgroup)
return 0;
retry:
ret = rmdir(cgroup);
if (ret && errno == EBUSY) {
Expand Down
2 changes: 2 additions & 0 deletions tools/testing/selftests/cgroup/cgroup_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
#define USEC_PER_SEC 1000000L
#define NSEC_PER_SEC 1000000000L

#define TEST_UID 65534 /* usually nobody, any !root is fine */

/*
* Checks if two given values differ by less than err% of their sum.
*/
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/cgroup/test_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ static int test_cgcore_thread_migration(const char *root)
*/
static int test_cgcore_lesser_euid_open(const char *root)
{
const uid_t test_euid = 65534; /* usually nobody, any !root is fine */
const uid_t test_euid = TEST_UID;
int ret = KSFT_FAIL;
char *cg_test_a = NULL, *cg_test_b = NULL;
char *cg_test_a_procs = NULL, *cg_test_b_procs = NULL;
Expand Down
2 changes: 1 addition & 1 deletion tools/testing/selftests/cgroup/test_cpuset_prs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
skip_test() {
echo "$1"
echo "Test SKIPPED"
exit 0
exit 4 # ksft_skip
}

[[ $(id -u) -eq 0 ]] || skip_test "Test must be run as root!"
Expand Down

0 comments on commit 1210142

Please sign in to comment.