Skip to content

Commit

Permalink
kconfig: do not hardcode "include/config/auto.conf" filename
Browse files Browse the repository at this point in the history
Regardless of KCONFIG_AUTOCONFIG, the filename written as a Make target
into "include/config/auto.conf.cmd" was always the default one.

Of course this doesn't make it work for the Kernel kbuild system, since
there the filename is hardcoded at several places in the Makefiles.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
  • Loading branch information
Markus Heidelberg authored and Sam Ravnborg committed Jun 9, 2009
1 parent 284026c commit 12122f6
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
20 changes: 12 additions & 8 deletions scripts/kconfig/confdata.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ const char *conf_get_configname(void)
return name ? name : ".config";
}

const char *conf_get_autoconfig_name(void)
{
char *name = getenv("KCONFIG_AUTOCONFIG");

return name ? name : "include/config/auto.conf";
}

static char *conf_expand_value(const char *in)
{
struct symbol *sym;
Expand Down Expand Up @@ -555,15 +562,14 @@ int conf_write(const char *name)

int conf_split_config(void)
{
char *name, path[128];
const char *name;
char path[128];
char *s, *d, c;
struct symbol *sym;
struct stat sb;
int res, i, fd;

name = getenv("KCONFIG_AUTOCONFIG");
if (!name)
name = "include/config/auto.conf";
name = conf_get_autoconfig_name();
conf_read_simple(name, S_DEF_AUTO);

if (chdir("include/config"))
Expand Down Expand Up @@ -670,7 +676,7 @@ int conf_write_autoconf(void)
{
struct symbol *sym;
const char *str;
char *name;
const char *name;
FILE *out, *out_h;
time_t now;
int i, l;
Expand Down Expand Up @@ -773,9 +779,7 @@ int conf_write_autoconf(void)
name = "include/linux/autoconf.h";
if (rename(".tmpconfig.h", name))
return 1;
name = getenv("KCONFIG_AUTOCONFIG");
if (!name)
name = "include/config/auto.conf";
name = conf_get_autoconfig_name();
/*
* This must be the last step, kbuild has a dependency on auto.conf
* and this marks the successful completion of the previous steps.
Expand Down
1 change: 1 addition & 0 deletions scripts/kconfig/lkc.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ char *zconf_curname(void);

/* confdata.c */
const char *conf_get_configname(void);
const char *conf_get_autoconfig_name(void);
char *conf_get_default_confname(void);
void sym_set_change_count(int count);
void sym_add_change_count(int count);
Expand Down
6 changes: 3 additions & 3 deletions scripts/kconfig/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ int file_write_dep(const char *name)
else
fprintf(out, "\t%s\n", file->name);
}
fprintf(out, "\ninclude/config/auto.conf: \\\n"
"\t$(deps_config)\n\n");
fprintf(out, "\n%s: \\\n"
"\t$(deps_config)\n\n", conf_get_autoconfig_name());

expr_list_for_each_sym(sym_env_list, e, sym) {
struct property *prop;
Expand All @@ -61,7 +61,7 @@ int file_write_dep(const char *name)
if (!value)
value = "";
fprintf(out, "ifneq \"$(%s)\" \"%s\"\n", env_sym->name, value);
fprintf(out, "include/config/auto.conf: FORCE\n");
fprintf(out, "%s: FORCE\n", conf_get_autoconfig_name());
fprintf(out, "endif\n");
}

Expand Down

0 comments on commit 12122f6

Please sign in to comment.