Skip to content

Commit

Permalink
net: sched: fix missing doc annotations
Browse files Browse the repository at this point in the history
"make htmldocs" complains otherwise:

.//net/core/gen_stats.c:168: warning: No description found for parameter 'running'
.//include/linux/netdevice.h:1867: warning: No description found for parameter 'qdisc_running_key'

Fixes: f9eb8ae ("net_sched: transform qdisc running bit into a seqcount")
Fixes: edb09eb ("net: sched: do not acquire qdisc spinlock in qdisc/class stats dump")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Jun 8, 2016
1 parent 40e4e71 commit 123b365
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion include/linux/netdevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,8 @@ enum netdev_priv_flags {
* @phydev: Physical device may attach itself
* for hardware timestamping
*
* @qdisc_tx_busylock: XXX: need comments on this one
* @qdisc_tx_busylock: lockdep class annotating Qdisc->busylock spinlock
* @qdisc_running_key: lockdep class annotating Qdisc->running seqcount
*
* @proto_down: protocol port state information can be sent to the
* switch driver and used to set the phys state of the
Expand Down
1 change: 1 addition & 0 deletions net/core/gen_stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ EXPORT_SYMBOL(__gnet_stats_copy_basic);

/**
* gnet_stats_copy_basic - copy basic statistics into statistic TLV
* @running: seqcount_t pointer
* @d: dumping handle
* @cpu: copy statistic per cpu
* @b: basic statistics
Expand Down

0 comments on commit 123b365

Please sign in to comment.