Skip to content

Commit

Permalink
ntfs3: rename put_ntfs ntfs3_free_sbi
Browse files Browse the repository at this point in the history
put_ntfs is a rather unconventional name for a function that frees the
sbi and associated resources.  Give it a more descriptive name and drop
the duplicate name in the top of the function comment.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Message-Id: <20230809220545.1308228-12-hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
  • Loading branch information
Christoph Hellwig authored and Christian Brauner committed Aug 10, 2023
1 parent 4abc9a4 commit 126dbf8
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions fs/ntfs3/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,9 +569,9 @@ static void init_once(void *foo)
}

/*
* put_ntfs - Noinline to reduce binary size.
* Noinline to reduce binary size.
*/
static noinline void put_ntfs(struct ntfs_sb_info *sbi)
static noinline void ntfs3_free_sbi(struct ntfs_sb_info *sbi)
{
kfree(sbi->new_rec);
kvfree(ntfs_put_shared(sbi->upcase));
Expand Down Expand Up @@ -627,7 +627,7 @@ static void ntfs_put_super(struct super_block *sb)
ntfs_set_state(sbi, NTFS_DIRTY_CLEAR);

put_mount_options(sbi->options);
put_ntfs(sbi);
ntfs3_free_sbi(sbi);
sb->s_fs_info = NULL;

sync_blockdev(sb->s_bdev);
Expand Down Expand Up @@ -1569,7 +1569,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
* ntfs_fs_free will be called with fc->s_fs_info = NULL
*/
put_mount_options(sbi->options);
put_ntfs(sbi);
ntfs3_free_sbi(sbi);
sb->s_fs_info = NULL;
kfree(boot2);

Expand Down Expand Up @@ -1659,7 +1659,7 @@ static void ntfs_fs_free(struct fs_context *fc)
struct ntfs_sb_info *sbi = fc->s_fs_info;

if (sbi)
put_ntfs(sbi);
ntfs3_free_sbi(sbi);

if (opts)
put_mount_options(opts);
Expand Down

0 comments on commit 126dbf8

Please sign in to comment.