Skip to content

Commit

Permalink
drivers: net: last_rx elimination
Browse files Browse the repository at this point in the history
Network drivers do not have to update last_rx, unless they need it for
their private use.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Apr 13, 2010
1 parent acbbc07 commit 127aa0e
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion drivers/net/bcm63xx_enet.c
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,6 @@ static int bcm_enet_receive_queue(struct net_device *dev, int budget)
skb->protocol = eth_type_trans(skb, dev);
priv->stats.rx_packets++;
priv->stats.rx_bytes += len;
dev->last_rx = jiffies;
netif_receive_skb(skb);

} while (--budget > 0);
Expand Down
2 changes: 0 additions & 2 deletions drivers/net/can/at91_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,6 @@ static int at91_poll_err(struct net_device *dev, int quota, u32 reg_sr)
at91_poll_err_frame(dev, cf, reg_sr);
netif_receive_skb(skb);

dev->last_rx = jiffies;
dev->stats.rx_packets++;
dev->stats.rx_bytes += cf->can_dlc;

Expand Down Expand Up @@ -898,7 +897,6 @@ static void at91_irq_err(struct net_device *dev)
at91_irq_err_state(dev, cf, new_state);
netif_rx(skb);

dev->last_rx = jiffies;
dev->stats.rx_packets++;
dev->stats.rx_bytes += cf->can_dlc;

Expand Down
1 change: 0 additions & 1 deletion drivers/net/ixgbevf/ixgbevf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,6 @@ static bool ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,
skb->protocol = eth_type_trans(skb, adapter->netdev);

ixgbevf_receive_skb(q_vector, skb, staterr, rx_ring, rx_desc);
adapter->netdev->last_rx = jiffies;

next_desc:
rx_desc->wb.upper.status_error = 0;
Expand Down
2 changes: 0 additions & 2 deletions drivers/net/ksz884x.c
Original file line number Diff line number Diff line change
Expand Up @@ -5054,8 +5054,6 @@ static inline int rx_proc(struct net_device *dev, struct ksz_hw* hw,
priv->stats.rx_bytes += packet_len;

/* Notify upper layer for received packet. */
dev->last_rx = jiffies;

rx_status = netif_rx(skb);

return 0;
Expand Down
1 change: 0 additions & 1 deletion drivers/net/octeon/octeon_mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ static int octeon_mgmt_receive_one(struct octeon_mgmt *p)
skb->protocol = eth_type_trans(skb, netdev);
netdev->stats.rx_packets++;
netdev->stats.rx_bytes += skb->len;
netdev->last_rx = jiffies;
netif_receive_skb(skb);
rc = 0;
} else if (re.s.code == RING_ENTRY_CODE_MORE) {
Expand Down
1 change: 0 additions & 1 deletion drivers/net/stmmac/stmmac_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,6 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit)

priv->dev->stats.rx_packets++;
priv->dev->stats.rx_bytes += frame_len;
priv->dev->last_rx = jiffies;
}
entry = next_entry;
p = p_next; /* use prefetched values */
Expand Down
1 change: 0 additions & 1 deletion drivers/net/vmxnet3/vmxnet3_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1174,7 +1174,6 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
netif_receive_skb(skb);
}

adapter->netdev->last_rx = jiffies;
ctx->skb = NULL;
}

Expand Down

0 comments on commit 127aa0e

Please sign in to comment.