Skip to content

Commit

Permalink
gpio: etraxfs: fix set register flag
Browse files Browse the repository at this point in the history
BGPIO_F_UNREADABLE_REG_SET is incorrect, since the set register _is_
readable.  What's really required is BGPIO_F_READ_OUTPUT_REG_SET:
reading the set register reads the set output value.

Signed-off-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Rabin Vincent authored and Linus Walleij committed Jul 27, 2015
1 parent 8cd1470 commit 1296fba
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpio/gpio-etraxfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ static int etraxfs_gpio_probe(struct platform_device *pdev)
NULL, /* clr */
regs + port->oe, /* dirout */
NULL, /* dirin */
BGPIOF_UNREADABLE_REG_SET);
BGPIOF_READ_OUTPUT_REG_SET);
if (ret)
return ret;

Expand Down

0 comments on commit 1296fba

Please sign in to comment.