Skip to content

Commit

Permalink
cfg80211: identically validate beacon interval for AP/MESH/IBSS
Browse files Browse the repository at this point in the history
Beacon interval interface combinations validation was missing
for MESH/IBSS join, add those.

Johannes: also move the beacon interval check disallowing really
tiny and really big intervals into the common function, which
adds it for AP mode.

Signed-off-by: Purushottam Kushwaha <pkushwah@qti.qualcomm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Purushottam Kushwaha authored and Johannes Berg committed Aug 11, 2016
1 parent 7f8ed01 commit 12d20fc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
16 changes: 9 additions & 7 deletions net/wireless/nl80211.c
Original file line number Diff line number Diff line change
Expand Up @@ -7752,12 +7752,13 @@ static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)

ibss.beacon_interval = 100;

if (info->attrs[NL80211_ATTR_BEACON_INTERVAL]) {
if (info->attrs[NL80211_ATTR_BEACON_INTERVAL])
ibss.beacon_interval =
nla_get_u32(info->attrs[NL80211_ATTR_BEACON_INTERVAL]);
if (ibss.beacon_interval < 1 || ibss.beacon_interval > 10000)
return -EINVAL;
}

err = cfg80211_validate_beacon_int(rdev, ibss.beacon_interval);
if (err)
return err;

if (!rdev->ops->join_ibss)
return -EOPNOTSUPP;
Expand Down Expand Up @@ -9231,9 +9232,10 @@ static int nl80211_join_mesh(struct sk_buff *skb, struct genl_info *info)
if (info->attrs[NL80211_ATTR_BEACON_INTERVAL]) {
setup.beacon_interval =
nla_get_u32(info->attrs[NL80211_ATTR_BEACON_INTERVAL]);
if (setup.beacon_interval < 10 ||
setup.beacon_interval > 10000)
return -EINVAL;

err = cfg80211_validate_beacon_int(rdev, setup.beacon_interval);
if (err)
return err;
}

if (info->attrs[NL80211_ATTR_DTIM_PERIOD]) {
Expand Down
2 changes: 1 addition & 1 deletion net/wireless/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ int cfg80211_validate_beacon_int(struct cfg80211_registered_device *rdev,
struct wireless_dev *wdev;
int res = 0;

if (!beacon_int)
if (beacon_int < 10 || beacon_int > 10000)
return -EINVAL;

list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) {
Expand Down

0 comments on commit 12d20fc

Please sign in to comment.