Skip to content

Commit

Permalink
selftests/memory-hotplug: Add checking after online or offline
Browse files Browse the repository at this point in the history
Add checking for online_memory_expect_success()/
offline_memory_expect_success()/offline_memory_expect_fail(), or
the test would exit 0 although the functions return 1.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
  • Loading branch information
Zhao Gongyi authored and Shuah Khan committed Oct 7, 2022
1 parent cadf306 commit 13023c3
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -266,15 +266,19 @@ done
#
echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error
for memory in `hotpluggable_offline_memory`; do
online_memory_expect_fail $memory
if ! online_memory_expect_fail $memory; then
retval=1
fi
done

#
# Online all hot-pluggable memory
#
echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error
for memory in `hotpluggable_offline_memory`; do
online_memory_expect_success $memory
if ! online_memory_expect_success $memory; then
retval=1
fi
done

#
Expand All @@ -283,7 +287,9 @@ done
echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
for memory in `hotpluggable_online_memory`; do
if [ $((RANDOM % 100)) -lt $ratio ]; then
offline_memory_expect_fail $memory
if ! offline_memory_expect_fail $memory; then
retval=1
fi
fi
done

Expand Down

0 comments on commit 13023c3

Please sign in to comment.