Skip to content

Commit

Permalink
net/mlx5: DR, Lower sync threshold for ICM hot memory
Browse files Browse the repository at this point in the history
Instead of hiding the math in the code, define a value that sets the
fraction of allowed hot memory of ICM pool.
Set the threshold for sync of ICM hot chunks to 1/4 of the pool
instead of 1/2 of the pool. Although we will have more syncs, each
sync will be shorter and will help with insertion rate stability.

Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Reviewed-by: Alex Vesker <valex@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
  • Loading branch information
Yevgeny Kliteynik authored and Saeed Mahameed committed Oct 27, 2022
1 parent fb628b7 commit 133ea37
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "dr_types.h"

#define DR_ICM_MODIFY_HDR_ALIGN_BASE 64
#define DR_ICM_POOL_HOT_MEMORY_FRACTION 4

struct mlx5dr_icm_pool {
enum mlx5dr_icm_type icm_type;
Expand Down Expand Up @@ -337,10 +338,11 @@ static bool dr_icm_pool_is_sync_required(struct mlx5dr_icm_pool *pool)
{
int allow_hot_size;

/* sync when hot memory reaches half of the pool size */
/* sync when hot memory reaches a certain fraction of the pool size */
allow_hot_size =
mlx5dr_icm_pool_chunk_size_to_byte(pool->max_log_chunk_sz,
pool->icm_type) / 2;
pool->icm_type) /
DR_ICM_POOL_HOT_MEMORY_FRACTION;

return pool->hot_memory_size > allow_hot_size;
}
Expand Down

0 comments on commit 133ea37

Please sign in to comment.