Skip to content

Commit

Permalink
serial: imx: drop if that always evaluates to true
Browse files Browse the repository at this point in the history
The check sts & USR1_DTRD was just evaluated to true two lines above.
So this change doesn't have any effect on the semantic of the driver.

Fixes: 27e1650 ("serial: imx: implement DSR irq handling for DTE mode")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Uwe Kleine-König authored and Greg Kroah-Hartman committed Feb 28, 2018
1 parent 0ef5a6e commit 135ccb0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/tty/serial/imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -781,8 +781,7 @@ static irqreturn_t imx_int(int irq, void *dev_id)
if (sts & USR1_DTRD) {
unsigned long flags;

if (sts & USR1_DTRD)
writel(USR1_DTRD, sport->port.membase + USR1);
writel(USR1_DTRD, sport->port.membase + USR1);

spin_lock_irqsave(&sport->port.lock, flags);
imx_mctrl_check(sport);
Expand Down

0 comments on commit 135ccb0

Please sign in to comment.