Skip to content

Commit

Permalink
EDAC/pnd2: Make read-only const array intlv static
Browse files Browse the repository at this point in the history
Don't populate the const read-only array intlv on the stack at run time,
instead make it static. This also shrinks the object size:

  $ size pnd2_edac.o.*

     text    data     bss     dec     hex filename
    15632     264    1384   17280    4380 pnd2_edac.o.new
    15644     264    1384   17292    438c pnd2_edac.o.old

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Link: https://lore.kernel.org/r/20240919170427.497429-1-colin.i.king@gmail.com
  • Loading branch information
Colin Ian King authored and Borislav Petkov (AMD) committed Mar 3, 2025
1 parent ac2fbe0 commit 136899f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/edac/pnd2_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ static int gen_asym_mask(struct b_cr_slice_channel_hash *p,
struct b_cr_asym_mem_region1_mchbar *as1,
struct b_cr_asym_2way_mem_region_mchbar *as2way)
{
const int intlv[] = { 0x5, 0xA, 0x3, 0xC };
static const int intlv[] = { 0x5, 0xA, 0x3, 0xC };
int mask = 0;

if (as2way->asym_2way_interleave_enable)
Expand Down Expand Up @@ -489,7 +489,7 @@ static int dnv_get_registers(void)
*/
static int get_registers(void)
{
const int intlv[] = { 10, 11, 12, 12 };
static const int intlv[] = { 10, 11, 12, 12 };

if (RD_REG(&tolud, b_cr_tolud_pci) ||
RD_REG(&touud_lo, b_cr_touud_lo_pci) ||
Expand Down

0 comments on commit 136899f

Please sign in to comment.