Skip to content

Commit

Permalink
wl1251: fix crash on remove due to premature kfree
Browse files Browse the repository at this point in the history
commit 328c32f upstream.

Currently SDIO glue frees it's own structure before calling
wl1251_free_hw(), which in turn calls ieee80211_unregister_hw().
The later call may result in a need to communicate with the chip
to stop it (as it happens now if the interface is still up before
rmmod), which means calls are made back to the glue, resulting in
freed memory access.

Fix this by freeing glue data last.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Grazvydas Ignotas authored and Greg Kroah-Hartman committed May 7, 2012
1 parent e4aef42 commit 137c55d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/wl1251/sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ static void __devexit wl1251_sdio_remove(struct sdio_func *func)

if (wl->irq)
free_irq(wl->irq, wl);
kfree(wl_sdio);
wl1251_free_hw(wl);
kfree(wl_sdio);

sdio_claim_host(func);
sdio_release_irq(func);
Expand Down

0 comments on commit 137c55d

Please sign in to comment.