Skip to content

Commit

Permalink
smack: Add missing logging in bidirectional UDS connect check
Browse files Browse the repository at this point in the history
During UDS connection check, both sides are checked for write access to
the other side. But only the first check is performed with audit support.
The second one didn't produce any audit logs. This simple patch fixes that.

Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
  • Loading branch information
Rafal Krypa authored and Casey Schaufler committed Jan 21, 2015
1 parent 69f287a commit 138a868
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion security/smack/smack_lsm.c
Original file line number Diff line number Diff line change
Expand Up @@ -3333,7 +3333,7 @@ static int smack_unix_stream_connect(struct sock *sock,
if (rc == 0) {
okp = osp->smk_out;
skp = ssp->smk_in;
rc = smk_access(okp, skp, MAY_WRITE, NULL);
rc = smk_access(okp, skp, MAY_WRITE, &ad);
rc = smk_bu_note("UDS connect", okp, skp,
MAY_WRITE, rc);
}
Expand Down

0 comments on commit 138a868

Please sign in to comment.