Skip to content

Commit

Permalink
ACPI: EC: Rearrange code in acpi_ec_submit_event()
Browse files Browse the repository at this point in the history
Rearange acpi_ec_event_handler() so as to avoid releasing ec->lock
and acquiring it again right away in the case when ec_event_clearing
is not ACPI_EC_EVT_TIMING_EVENT.

This also reduces the number of checks done by acpi_ec_event_handler()
in that case.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Rafael J. Wysocki committed Feb 14, 2022
1 parent 54b8614 commit 13a62d0
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions drivers/acpi/ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,7 @@ static void acpi_ec_event_handler(struct work_struct *work)
acpi_ec_submit_query(ec);

spin_lock_irq(&ec->lock);

ec->events_to_process--;
}

Expand All @@ -1246,27 +1247,30 @@ static void acpi_ec_event_handler(struct work_struct *work)
* event handling work again regardless of whether or not the query
* queued up above is processed successfully.
*/
if (ec_event_clearing == ACPI_EC_EVT_TIMING_EVENT)
if (ec_event_clearing == ACPI_EC_EVT_TIMING_EVENT) {
bool guard_timeout;

acpi_ec_complete_event(ec);
else
acpi_ec_close_event(ec);

spin_unlock_irq(&ec->lock);
ec_dbg_evt("Event stopped");

spin_unlock_irq(&ec->lock);

ec_dbg_evt("Event stopped");
guard_timeout = !!ec_guard(ec);

if (ec_event_clearing == ACPI_EC_EVT_TIMING_EVENT && ec_guard(ec)) {
spin_lock_irq(&ec->lock);

/* Take care of SCI_EVT unless someone else is doing that. */
if (!ec->curr)
if (guard_timeout && !ec->curr)
advance_transaction(ec, false);
} else {
acpi_ec_close_event(ec);

spin_unlock_irq(&ec->lock);
ec_dbg_evt("Event stopped");
}

spin_lock_irq(&ec->lock);
ec->events_in_progress--;

spin_unlock_irq(&ec->lock);
}

Expand Down

0 comments on commit 13a62d0

Please sign in to comment.