Skip to content

Commit

Permalink
ALSA: hda/ca0132 - Fix recording from mode id 0x8
Browse files Browse the repository at this point in the history
Incorrect ADC is picked in ca0132_capture_pcm_prepare(),
where it assumes multiple streams while there is one stream
per ADC. Note that ca0132_capture_pcm_cleanup() already does
the right thing.

The Chromebook Pixel has a microphone under the keyboard that
is attached to node id 0x8. Before this fix, recording would
always go to the main internal mic (node id 0x7).

Signed-off-by: Hsin-Yu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Hsin-Yu Chao authored and Takashi Iwai committed Feb 19, 2014
1 parent 28fba95 commit 13c12db
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions sound/pci/hda/patch_ca0132.c
Original file line number Diff line number Diff line change
Expand Up @@ -2768,9 +2768,7 @@ static int ca0132_capture_pcm_prepare(struct hda_pcm_stream *hinfo,
unsigned int format,
struct snd_pcm_substream *substream)
{
struct ca0132_spec *spec = codec->spec;

snd_hda_codec_setup_stream(codec, spec->adcs[substream->number],
snd_hda_codec_setup_stream(codec, hinfo->nid,
stream_tag, 0, format);

return 0;
Expand Down

0 comments on commit 13c12db

Please sign in to comment.