Skip to content

Commit

Permalink
nilfs2: fix misuse of open_bdev_exclusive/close_bdev_exclusive
Browse files Browse the repository at this point in the history
The second argument of open_bdev_exclusive/close_bdev_exclusive takes
fmode_t flags instead of mount flags.  This fixes the misuse.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
  • Loading branch information
Ryusuke Konishi committed May 10, 2010
1 parent 400ade8 commit 13e9055
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions fs/nilfs2/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -998,10 +998,14 @@ nilfs_get_sb(struct file_system_type *fs_type, int flags,
{
struct nilfs_super_data sd;
struct super_block *s;
fmode_t mode = FMODE_READ;
struct the_nilfs *nilfs;
int err, need_to_close = 1;

sd.bdev = open_bdev_exclusive(dev_name, flags, fs_type);
if (!(flags & MS_RDONLY))
mode |= FMODE_WRITE;

sd.bdev = open_bdev_exclusive(dev_name, mode, fs_type);
if (IS_ERR(sd.bdev))
return PTR_ERR(sd.bdev);

Expand Down Expand Up @@ -1082,15 +1086,15 @@ nilfs_get_sb(struct file_system_type *fs_type, int flags,
mutex_unlock(&nilfs->ns_mount_mutex);
put_nilfs(nilfs);
if (need_to_close)
close_bdev_exclusive(sd.bdev, flags);
close_bdev_exclusive(sd.bdev, mode);
simple_set_mnt(mnt, s);
return 0;

failed_unlock:
mutex_unlock(&nilfs->ns_mount_mutex);
put_nilfs(nilfs);
failed:
close_bdev_exclusive(sd.bdev, flags);
close_bdev_exclusive(sd.bdev, mode);

return err;

Expand Down

0 comments on commit 13e9055

Please sign in to comment.