Skip to content

Commit

Permalink
PM / core: Simplify initcall_debug_report() timing
Browse files Browse the repository at this point in the history
initcall_debug_report() always called ktime_get(), even if we didn't
need the result.

Change it so we only call it when we're going to use the result, and
change initcall_debug_start() to follow the same style.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Rafael J. Wysocki committed May 10, 2018
1 parent 147f297 commit 143711f
Showing 1 changed file with 11 additions and 13 deletions.
24 changes: 11 additions & 13 deletions drivers/base/power/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,13 @@ void device_pm_move_last(struct device *dev)

static ktime_t initcall_debug_start(struct device *dev)
{
ktime_t calltime = 0;

if (pm_print_times_enabled) {
pr_info("calling %s+ @ %i, parent: %s\n",
dev_name(dev), task_pid_nr(current),
dev->parent ? dev_name(dev->parent) : "none");
calltime = ktime_get();
}
if (!pm_print_times_enabled)
return 0;

return calltime;
pr_info("calling %s+ @ %i, parent: %s\n",
dev_name(dev), task_pid_nr(current),
dev->parent ? dev_name(dev->parent) : "none");
return ktime_get();
}

static void initcall_debug_report(struct device *dev, ktime_t calltime,
Expand All @@ -212,13 +209,14 @@ static void initcall_debug_report(struct device *dev, ktime_t calltime,
ktime_t rettime;
s64 nsecs;

if (!pm_print_times_enabled)
return;

rettime = ktime_get();
nsecs = (s64) ktime_to_ns(ktime_sub(rettime, calltime));

if (pm_print_times_enabled) {
pr_info("call %s+ returned %d after %Ld usecs\n", dev_name(dev),
error, (unsigned long long)nsecs >> 10);
}
pr_info("call %s+ returned %d after %Ld usecs\n", dev_name(dev),
error, (unsigned long long)nsecs >> 10);
}

/**
Expand Down

0 comments on commit 143711f

Please sign in to comment.