Skip to content

Commit

Permalink
component: allow missing unbind callback
Browse files Browse the repository at this point in the history
The component framework reuses the devres managed functions. There is no
need to specify an unbind() callback if the driver only wants to release
the devres managed resources. The bind/unbind is like the probe/remove
pair. The bind/probe is necessary and the unbind/remove is optional.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20200227104547.30085-1-m.felsch@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Marco Felsch authored and Greg Kroah-Hartman committed Mar 18, 2020
1 parent 526ee72 commit 14422f1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/base/component.c
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,8 @@ static void component_unbind(struct component *component,
{
WARN_ON(!component->bound);

component->ops->unbind(component->dev, master->dev, data);
if (component->ops && component->ops->unbind)
component->ops->unbind(component->dev, master->dev, data);
component->bound = false;

/* Release all resources claimed in the binding of this component */
Expand Down

0 comments on commit 14422f1

Please sign in to comment.