Skip to content

Commit

Permalink
usb: host: ohci-pxa27x: use of_property_read_bool()
Browse files Browse the repository at this point in the history
for checking if a property is present or not,
of_property_read_bool is more appropriate than of_get_property()

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Saurabh Sengar authored and Greg Kroah-Hartman committed Dec 1, 2015
1 parent b36d839 commit 144e38c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/usb/host/ohci-pxa27x.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,19 +365,19 @@ static int ohci_pxa_of_init(struct platform_device *pdev)
if (!pdata)
return -ENOMEM;

if (of_get_property(np, "marvell,enable-port1", NULL))
if (of_property_read_bool(np, "marvell,enable-port1"))
pdata->flags |= ENABLE_PORT1;
if (of_get_property(np, "marvell,enable-port2", NULL))
if (of_property_read_bool(np, "marvell,enable-port2"))
pdata->flags |= ENABLE_PORT2;
if (of_get_property(np, "marvell,enable-port3", NULL))
if (of_property_read_bool(np, "marvell,enable-port3"))
pdata->flags |= ENABLE_PORT3;
if (of_get_property(np, "marvell,port-sense-low", NULL))
if (of_property_read_bool(np, "marvell,port-sense-low"))
pdata->flags |= POWER_SENSE_LOW;
if (of_get_property(np, "marvell,power-control-low", NULL))
if (of_property_read_bool(np, "marvell,power-control-low"))
pdata->flags |= POWER_CONTROL_LOW;
if (of_get_property(np, "marvell,no-oc-protection", NULL))
if (of_property_read_bool(np, "marvell,no-oc-protection"))
pdata->flags |= NO_OC_PROTECTION;
if (of_get_property(np, "marvell,oc-mode-perport", NULL))
if (of_property_read_bool(np, "marvell,oc-mode-perport"))
pdata->flags |= OC_MODE_PERPORT;
if (!of_property_read_u32(np, "marvell,power-on-delay", &tmp))
pdata->power_on_delay = tmp;
Expand Down

0 comments on commit 144e38c

Please sign in to comment.