Skip to content

Commit

Permalink
ucc_geth: Intialize link state to down before register_netdev
Browse files Browse the repository at this point in the history
ucc_geth was indicating link up after a port is administratively enabled even
when nothing is plugged in.  This causes user-space tools to see a spurious link
up the first time after boot.

Signed-off-by: Cliff Clark <cliff_clark@selinc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Cliff Clark authored and David S. Miller committed Mar 24, 2015
1 parent 8ad4837 commit 1452db7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ethernet/freescale/ucc_geth.c
Original file line number Diff line number Diff line change
Expand Up @@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device* ofdev)
ugeth->phy_interface = phy_interface;
ugeth->max_speed = max_speed;

/* Carrier starts down, phylib will bring it up */
netif_carrier_off(dev);

err = register_netdev(dev);
if (err) {
if (netif_msg_probe(ugeth))
Expand Down

0 comments on commit 1452db7

Please sign in to comment.