Skip to content

Commit

Permalink
sched/deadline: Use online cpus for validating runtime
Browse files Browse the repository at this point in the history
The ftrace selftest reported a failure because writing -1 to
sched_rt_runtime_us returns -EBUSY. This happens when the possible
CPUs are different from active CPUs.

Active CPUs are part of one root domain, while remaining CPUs are part
of def_root_domain. Since active cpumask is being used, this results in
cpus=0 when a non active CPUs is used in the loop.

Fix it by looping over the online CPUs instead for validating the
bandwidth calculations.

Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Juri Lelli <juri.lelli@redhat.com>
Link: https://lore.kernel.org/r/20250306052954.452005-2-sshegde@linux.ibm.com
  • Loading branch information
Shrikanth Hegde authored and Ingo Molnar committed Mar 6, 2025
1 parent 3b4035d commit 14672f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/sched/deadline.c
Original file line number Diff line number Diff line change
Expand Up @@ -3189,7 +3189,7 @@ int sched_dl_global_validate(void)
* value smaller than the currently allocated bandwidth in
* any of the root_domains.
*/
for_each_possible_cpu(cpu) {
for_each_online_cpu(cpu) {
rcu_read_lock_sched();

if (dl_bw_visited(cpu, gen))
Expand Down

0 comments on commit 14672f0

Please sign in to comment.