Skip to content

Commit

Permalink
iommu: Delete iommu_dma_free_cpu_cached_iovas()
Browse files Browse the repository at this point in the history
Function iommu_dma_free_cpu_cached_iovas() no longer has any caller, so
delete it.

With that, function free_cpu_cached_iovas() may be made static.

Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/1616675401-151997-4-git-send-email-john.garry@huawei.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
John Garry authored and Joerg Roedel committed Apr 7, 2021
1 parent 363f266 commit 149448b
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 20 deletions.
9 changes: 0 additions & 9 deletions drivers/iommu/dma-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,6 @@ static int __init iommu_dma_forcedac_setup(char *str)
}
early_param("iommu.forcedac", iommu_dma_forcedac_setup);

void iommu_dma_free_cpu_cached_iovas(unsigned int cpu,
struct iommu_domain *domain)
{
struct iommu_dma_cookie *cookie = domain->iova_cookie;
struct iova_domain *iovad = &cookie->iovad;

free_cpu_cached_iovas(cpu, iovad);
}

static void iommu_dma_entry_dtor(unsigned long data)
{
struct page *freelist = (struct page *)data;
Expand Down
3 changes: 2 additions & 1 deletion drivers/iommu/iova.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ static unsigned long iova_rcache_get(struct iova_domain *iovad,
unsigned long size,
unsigned long limit_pfn);
static void init_iova_rcaches(struct iova_domain *iovad);
static void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad);
static void free_iova_rcaches(struct iova_domain *iovad);
static void fq_destroy_all_entries(struct iova_domain *iovad);
static void fq_flush_timeout(struct timer_list *t);
Expand Down Expand Up @@ -1040,7 +1041,7 @@ static void free_iova_rcaches(struct iova_domain *iovad)
/*
* free all the IOVA ranges cached by a cpu (used when cpu is unplugged)
*/
void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad)
static void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad)
{
struct iova_cpu_rcache *cpu_rcache;
struct iova_rcache *rcache;
Expand Down
5 changes: 0 additions & 5 deletions include/linux/dma-iommu.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,5 @@ static inline void iommu_dma_get_resv_regions(struct device *dev, struct list_he
{
}

static inline void iommu_dma_free_cpu_cached_iovas(unsigned int cpu,
struct iommu_domain *domain)
{
}

#endif /* CONFIG_IOMMU_DMA */
#endif /* __DMA_IOMMU_H */
5 changes: 0 additions & 5 deletions include/linux/iova.h
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ int init_iova_flush_queue(struct iova_domain *iovad,
iova_flush_cb flush_cb, iova_entry_dtor entry_dtor);
struct iova *find_iova(struct iova_domain *iovad, unsigned long pfn);
void put_iova_domain(struct iova_domain *iovad);
void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad);
#else
static inline int iova_cache_get(void)
{
Expand Down Expand Up @@ -234,10 +233,6 @@ static inline void put_iova_domain(struct iova_domain *iovad)
{
}

static inline void free_cpu_cached_iovas(unsigned int cpu,
struct iova_domain *iovad)
{
}
#endif

#endif

0 comments on commit 149448b

Please sign in to comment.