Skip to content

Commit

Permalink
greybus: tracing: assign "parent" id first
Browse files Browse the repository at this point in the history
Most abstractions to be traced will have a sort of "parent" object
it is associated with, and an identifier for that parent is stored
with the as trace event data.  For example, the parent of a message
is the operation it's a part of, and the parent of an operation is
the connection it uses.

We'll arrange to define that parent id first in all events.  Most
abstractions already do this.  Move an interface's module id so it's
defined and assigned first.  The message traces are going to be
changed soon, so leave that one alone.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
  • Loading branch information
Alex Elder authored and Greg Kroah-Hartman committed Jun 4, 2016
1 parent c65fdf0 commit 14a36ae
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/greybus/greybus_trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ DECLARE_EVENT_CLASS(gb_interface,
TP_ARGS(intf),

TP_STRUCT__entry(
__field(u8, id) /* Interface id */
__field(u8, module_id)
__field(u8, id) /* Interface id */
__field(u8, device_id)
__field(int, disconnected) /* bool */
__field(int, ejected) /* bool */
Expand All @@ -178,8 +178,8 @@ DECLARE_EVENT_CLASS(gb_interface,
),

TP_fast_assign(
__entry->id = intf->interface_id;
__entry->module_id = intf->module->module_id;
__entry->id = intf->interface_id;
__entry->device_id = intf->device_id;
__entry->disconnected = intf->disconnected;
__entry->ejected = intf->ejected;
Expand Down

0 comments on commit 14a36ae

Please sign in to comment.