Skip to content

Commit

Permalink
sti: no need to check return value of debugfs_create functions
Browse files Browse the repository at this point in the history
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613114618.GD13119@kroah.com
  • Loading branch information
Greg Kroah-Hartman authored and Benjamin Gaignard committed Jun 13, 2019
1 parent b792e64 commit 150c662
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/gpu/drm/sti/sti_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ static struct drm_info_list sti_drm_dbg_list[] = {

static int sti_drm_dbg_init(struct drm_minor *minor)
{
struct dentry *dentry;
int ret;

ret = drm_debugfs_create_files(sti_drm_dbg_list,
Expand All @@ -105,13 +104,8 @@ static int sti_drm_dbg_init(struct drm_minor *minor)
if (ret)
goto err;

dentry = debugfs_create_file("fps_show", S_IRUGO | S_IWUSR,
minor->debugfs_root, minor->dev,
&sti_drm_fps_fops);
if (!dentry) {
ret = -ENOMEM;
goto err;
}
debugfs_create_file("fps_show", S_IRUGO | S_IWUSR, minor->debugfs_root,
minor->dev, &sti_drm_fps_fops);

DRM_INFO("%s: debugfs installed\n", DRIVER_NAME);
return 0;
Expand Down

0 comments on commit 150c662

Please sign in to comment.