Skip to content

Commit

Permalink
[media] v4l2-mc: remove the unused sensor var
Browse files Browse the repository at this point in the history
This fixes this warning:

	v4l2-mc.c: In function 'v4l2_mc_create_media_graph':
	v4l2-mc.c:60:69: warning: variable 'sensor' set but not used [-Wunused-but-set-variable]

We could solve it the other way: don't do the second loop for
webcams. However, that would fail if a chip would have two sensors
plugged. This is not the current case, but it doesn't hurt to be
future-safe here, specially since this code runs only once during
device probe. So, performance is not an issue here.

Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
  • Loading branch information
Mauro Carvalho Chehab committed Feb 16, 2016
1 parent 6168309 commit 153d41a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/media/v4l2-core/v4l2-mc.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ int v4l2_mc_create_media_graph(struct media_device *mdev)

{
struct media_entity *entity;
struct media_entity *if_vid = NULL, *if_aud = NULL, *sensor = NULL;
struct media_entity *if_vid = NULL, *if_aud = NULL;
struct media_entity *tuner = NULL, *decoder = NULL;
struct media_entity *io_v4l = NULL, *io_vbi = NULL, *io_swradio = NULL;
bool is_webcam = false;
Expand Down Expand Up @@ -130,7 +130,6 @@ int v4l2_mc_create_media_graph(struct media_device *mdev)
io_swradio = entity;
break;
case MEDIA_ENT_F_CAM_SENSOR:
sensor = entity;
is_webcam = true;
break;
}
Expand Down

0 comments on commit 153d41a

Please sign in to comment.